8000 chore: Remove embedded Python vllm and sglang engines by grahamking · Pull Request #966 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Remove embedded Python vllm and sglang engines #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

chore: Remove embedded Python vllm and sglang engines #966

merged 3 commits into from
May 7, 2025

Conversation

grahamking
Copy link
Contributor

What a cleanup! A breath of fresh air.

vllm and sglang are now the sub-process engines from #954

This means unless you build with --feature python, dynamo-run does not link libpython.

@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from 8234519 to 1aa1a51 Compare May 6, 2025 21:51
@grahamking grahamking requested a review from ishandhanani as a code owner May 6, 2025 21:51
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from 1aa1a51 to 550f65c Compare May 6, 2025 22:13
rmccorm4
rmccorm4 reviewed May 6, 2025
View reviewed changes
rmccorm4
rmccorm4 reviewed May 6, 2025
View reviewed changes
rmccorm4
rmccorm4 reviewed May 6, 2025
View reviewed changes
rmccorm4
rmccorm4 reviewed May 6, 2025
View reviewed changes
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from 4267095 to 8274871 Compare May 7, 2025 13:04
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from 8274871 to d72fdb4 Compare May 7, 2025 14:46
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from d72fdb4 to 4fd2083 Compare May 7, 2025 14:51
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from 4fd2083 to b43f283 Compare May 7, 2025 14:54
grahamking added 2 commits May 7, 2025 11:18
@grahamking
chore: Remove embedded Python vllm and sglang engines
7a6a931 
What a cleanup! A breath of fresh air.

vllm and sglang are now the sub-process engines from #954

This means unless you build with `--feature python`, dynamo-run does not
link `libpython`.
@grahamking
chore: Restore and update
ce3de98 
- Restore listing all used features in build command for clarity.
- Remove llamacpp from default features, that will be it's own commit
  (need to address CI libclang).
- Doc fixes from feedback.
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from b43f283 to d33da9b Compare May 7, 2025 15:19
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from d33da9b to 0424786 Compare May 7, 2025 15:34
@grahamking
chore: Replace bring-your-own-engine with write-your-own-engine
8a76453 
Instead of passing a Python file to `dynamo-run` you can now use
`dynamo-llm` bindings in a regular Python script. Much simpler.

Update the docs, and remove the `pytok` engine. We keep the `pystr`
engine for now because trt-llm uses it.
@grahamking grahamking force-pushed the gk-remove-embedded-python-1 branch from 0424786 to 8a76453 Compare May 7, 2025 16:08
@grahamking grahamking enabled auto-merge (squash) May 7, 2025 16:10
@grahamking grahamking merged commit 4296980 into main May 7, 2025
10 of 11 checks passed
@grahamking grahamking deleted the gk-remove-embedded-python-1 branch May 7, 2025 16:34
@grahamking grahamking mentioned this pull request May 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia piotrm-nvidia is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner

@tedzhouhk tedzhouhk Awaiting requested review from tedzhouhk tedzhouhk is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

@jthomson04 jthomson04 Awaiting requested review from jthomson04 jthomson04 is a code owner

@oandreeva-nv oandreeva-nv Awaiting requested review from oandreeva-nv oandreeva-nv is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani 5162 ishandhanani is a code owner

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamking @rmccorm4
0