8000 fix: default docker username and password are empty by hhzhang16 · Pull Request #926 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: default docker username and password are empty #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to 8000 your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

fix: default docker username and password are empty #926

merged 1 commit into from
May 1, 2025

Conversation

hhzhang16
Copy link
Contributor

Overview:

Have the default username and password for docker be empty in the deploy script so that a secret is not created.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented May 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hhzhang16 hhzhang16 merged commit f122aa4 into main May 1, 2025
7 checks passed
@hhzhang16 hhzhang16 deleted the hannahz/quick-deploy-fix branch May 1, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienmancuso julienmancuso julienmancuso approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@mohammedabdulwahhab mohammedabdulwahhab Awaiting requested review from mohammedabdulwahhab mohammedabdulwahhab is a code owner

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhzhang16 @julienmancuso
0