8000 fix: trtllm example by biswapanda · Pull Request #909 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: trtllm example #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

fix: trtllm example #909

merged 3 commits into from
Apr 30, 2025

Conversation

biswapanda
Copy link
Contributor

Overview:

fix trtllm example after #788 changes

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@biswapanda biswapanda self-assigned this Apr 30, 2025
@biswapanda biswapanda enabled auto-merge (squash) April 30, 2025 07:39
rmccorm4
rmccorm4 reviewed Apr 30, 2025
View reviewed changes
rmccorm4
rmccorm4 approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the logical change since there were no issues seen with vLLM equivalent examples that already included this change, but I haven't verified all the TRTLLM examples with this change manually myself.

@rmccorm4
Copy link
Contributor

Fixes #911

@biswapanda biswapanda disabled auto-merge April 30, 2025 22:15
@biswapanda biswapanda enabled auto-merge (squash) April 30, 2025 23:26
@biswapanda biswapanda merged commit 49517f2 into main Apr 30, 2025
10 checks passed
@biswapanda biswapanda deleted the bis/fix-trtllm-example branch April 30, 2025 23:51
biswapanda added a commit that referenced this pull request May 1, 2025
@biswapanda
fix: trtllm example (#909)
89af4f4
@biswapanda biswapanda mentioned this pull request May 1, 2025
Closed
@rmccorm4 rmccorm4 mentioned this pull request May 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@hhzhang16 hhzhang16 hhzhang16 approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@julienmancuso julienmancuso Awaiting requested review from julienmancuso julienmancuso is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia piotrm-nvidia is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@grahamking grahamking Awaiting requested review from grahamking grahamking is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner 8000

@tedzhouhk tedzhouhk Awaiting requested review from tedzhouhk tedzhouhk is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

@sshchoi sshchoi Awaiting requested review from sshchoi sshchoi is a code owner

@PeaBrane PeaBrane Awaiting requested review from PeaBrane PeaBrane is a code owner

@mohammedabdulwahhab mohammedabdulwahhab Awaiting requested review from mohammedabdulwahhab mohammedabdulwahhab is a code owner

Assignees

@biswapanda biswapanda

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@biswapanda @rmccorm4 @tanmayv25 @hhzhang16
0