8000 chore(dynamo-llm): Move the pre-processor to ingress side by grahamking · Pull Request #903 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(dynamo-llm): Move the pre-processor to ingress side #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

chore(dynamo-llm): Move the pre-processor to ingress side #903

merged 2 commits into from
May 1, 2025

Conversation

grahamking
Copy link
Contributor

Part of #743

oandreeva-nv
oandreeva-nv reviewed Apr 29, 2025
View reviewed changes
oandreeva-nv
oandreeva-nv reviewed Apr 29, 2025
View reviewed changes
@grahamking grahamking marked this pull request as draft April 30, 2025 13:01
@grahamking grahamking marked this pull request as ready for review May 1, 2025 14:49
oandreeva-nv
oandreeva-nv reviewed May 1, 2025
View reviewed changes
oandreeva-nv
oandreeva-nv reviewed May 1, 2025
View reviewed changes
oandreeva-nv
oandreeva-nv reviewed May 1, 2025
View reviewed changes
oandreeva-nv
oandreeva-nv reviewed May 1, 2025
View reviewed changes
oandreeva-nv
oandreeva-nv reviewed May 1, 2025
View reviewed changes
Copy link
Contributor
@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left some comments

oandreeva-nv
oandreeva-nv reviewed May 1, 2025
View reviewed changes
grahamking and others added 2 commits May 1, 2025 15:27
@grahamking
chore(dynamo-llm): Move the pre-processor to ingress side
505bbd4 
Part of #743
@grahamking @oandreeva-nv
Update components/http/src/main.rs
eeafd35 
Co-authored-by: Olga Andreeva <124622579+oandreeva-nv@users.noreply.github.com>
Signed-off-by: Graham King <graham@gkgk.org>
oandreeva-nv
oandreeva-nv approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor
@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason 8000 will be displayed to describe this comment to others. Learn more.

LGTM

@grahamking grahamking enabled auto-merge (squash) May 1, 2025 19:42
@grahamking grahamking merged commit 2d2a102 into main May 1, 2025
10 of 11 checks passed
@grahamking grahamking deleted the gk-preproc-move2 branch May 1, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oandreeva-nv oandreeva-nv oandreeva-nv approved these changes

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4 rmccorm4 is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamking @oandreeva-nv
0