8000 feat: rename operator CRDs by julienmancuso · Pull Request #795 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: rename operator CRDs #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

feat: rename operator CRDs #795

merged 4 commits into from
Apr 23, 2025

Conversation

julienmancuso
Copy link
Contributor
@julienmancuso julienmancuso commented Apr 23, 2025 •
edited
Loading

Overview:

rename operator CRDs

DynamoDeployment -> DynamoGraphDeployment
DynamoNimDeployment -> DynamoComponentDeployment
DynamoNim -> DynamoComponent
DynamoNimRequest -> DynamoComponentRequest

tested install from scratch and deployment of helloworld in jsm2 namespace

Details:

rename operator CRDs

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

hhzhang16
hhzhang16 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor
@hhzhang16 hhzhang16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienmancuso julienmancuso merged commit 26fe79d into main Apr 23, 2025
12 checks passed
@julienmancuso julienmancuso deleted the jsm/794 branch April 23, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhzhang16 hhzhang16 hhzhang16 approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@mohammedabdulwahhab mohammedabdulwahhab Awaiting requested review from mohammedabdulwahhab mohammedabdulwahhab is a code owner

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienmancuso @hhzhang16
0