8000 build: add rust binaries in manylinux image by nv-anants · Pull Request #783 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build: add rust binaries in manylinux image #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

build: add rust binaries in manylinux image #783

merged 3 commits into from
Apr 23, 2025

Conversation

nv-anants
Copy link
Contributor
@nv-anants nv-anants commented Apr 22, 2025 •
edited
Loading

Fixes #773

  • Build Rust binaries (packaged in python wheel) as part of manylinux image
  • Rust binaries link to docker image glibc version, 2.28 in manylinux image
  • Rest of the rust crates are built same as before, in ubuntu24 cuda container as some of them require dependencies like libclang etc which are present in ubuntu24 container

ToDo:

  1. dynamo-run and other rust binaries still link to libpython3.12. Need to package and distribute rust binaries in a different python wheel.
  2. Implement rust caching to avoid rebuilds in different container images

Tested install on ubuntu22.
objdump version for 0.1.1 release wheel binary

objdump -T /.venv/lib/python3.12/site-packages/dynamo/sdk/cli/bin/dynamo-run | grep GLIBC_ | sed -n 's/.*GLIBC_\(.*\)/\1/p' | sort -Vr
2.39) pidfd_spawnp
2.39) pidfd_getpid
2.38) __isoc23_strtol
2.38) strlcpy
2.38) fmod
2.34) __libc_start_main
2.34) pthread_setspecific
2.34) pthread_setname_np
2.34) pthread_mutex_trylock
...

objdump for new wheel binary -

objdump -T /.venv/lib/python3.12/site-packages/dynamo/sdk/cli/bin/dynamo-run | grep GLIBC_ | sed -n 's/.*GLIBC_\(.*\)/\1/p' | sort -Vr 
2.28) statx
2.27) powf
2.27) logf
2.27) expf
..

@nv-anants nv-anants marked this pull request as ready for review April 23, 2025 15:10
dmitry-tokarev-nv
dmitry-tokarev-nv reviewed Apr 23, 2025
View reviewed changes
@nv-anants nv-anants merged commit ea84ab1 into main Apr 23, 2025
9 checks passed
@nv-anants nv-anants deleted the anants/cargo-build-manylinux branch April 23, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnshah1 nnshah1 nnshah1 approved these changes

@dmitry-tokarev-nv dmitry-tokarev-nv dmitry-tokarev-nv approved these changes

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4 rmccorm4 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Failed to run dynamo-run 0.1.1.post1 on Ubuntu 22.04
3 participants
@nv-anants @nnshah1 @dmitry-tokarev-nv
0