feat: add custom lease to worker components #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
reviewed
Apr 19, 2025
rmccorm4
reviewed
Apr 19, 2025
rmccorm4
approved these changes
Apr 19, 2025
tedzhouhk
approved these changes
Apr 19, 2025
mohammedabdulwahhab
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a clean graceful shutown - we need to ensure that each worker is created with a custom lease. This allows the worker to shutdown without affecting the primary lease.
As a side note - this is one of the first times since GTC where we've done this sort of wiring of something that was written in rust into our bentoml way of serving. I'd like to move away from this and have a much much cleaner connection between the rust code and how our python examples leverage it
@tedzhouhk I believe this wires up both of the TODOs
generateuses the lease inserve_dynamo.pymetricsuses the lease via the new bindings in theworker.pyAn open question is if we always want a custom lease for the worker?
TLDR - wiring up #730