8000 fix: dynamo deploy helm chart cleanup by mohammedabdulwahhab · Pull Request #727 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: dynamo deploy helm chart cleanup #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2025
Merged

fix: dynamo deploy helm chart cleanup #727

merged 5 commits into from
Apr 18, 2025

Conversation

mohammedabdulwahhab
Copy link
Contributor
@mohammedabdulwahhab mohammedabdulwahhab commented Apr 17, 2025 •
edited
Loading

Overview:

  • add callouts for deps on istio and default storage class
  • remove explicit references to local-path from values so that default storage class can be used
  • simplify READMEs to remove unnecessary args CI_COMMIT_SHA
  • push back defaults to values.yaml (there were too many values present in the dynamo-platform-values.yaml file which should be reserved for overrides)
  • remove ngc_token other nvidia-internal references from values and readme

Testing

Minikube deployment from scratch succeeds and hello world works

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Apr 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

julienmancuso
julienmancuso reviewed Apr 17, 2025
View reviewed changes
@mohammedabdulwahhab mohammedabdulwahhab merged commit 831bc72 into main Apr 18, 2025
8 checks passed
@mohammedabdulwahhab mohammedabdulwahhab deleted the mabdulwahhab/minikube-dynamo-deploy branch April 18, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienmancuso julienmancuso julienmancuso left review comments

@hutm hutm hutm approved these changes

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@hhzhang16 hhzhang16 Awaiting requested review from hhzhang16 hhzhang16 is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammedabdulwahhab @hutm @julienmancuso
0