8000 docs: R1 disaggregation guide by GuanLuo · Pull Request #720 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: R1 disaggregation guide #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

docs: R1 disaggregation guide #720

merged 4 commits into from
Apr 22, 2025

Conversation

GuanLuo
Copy link
Contributor
@GuanLuo GuanLuo commented Apr 17, 2025

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Apr 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pull-request-size pull-request-size bot 8000 added the size/M label Apr 17, 2025
@tlipoca9
Copy link
Contributor

Has the issue #513 been resolved?

Base automatically changed from gluo/multi-node-aggregated to main April 18, 2025 22:09
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 18, 2025
@GuanLuo GuanLuo force-pushed the gluo/multi-node-disagg branch from b8b7b80 to c962b09 Compare April 21, 2025 17:31
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 21, 2025
@GuanLuo GuanLuo changed the title docs: R1 disaggregation [WIP] docs: R1 disaggregation guide Apr 21, 2025
@GuanLuo GuanLuo marked this pull request as ready for review April 21, 2025 17:32
rmccorm4
rmccorm4 reviewed Apr 21, 2025
View reviewed changes
@GuanLuo
Copy link
Contributor Author
GuanLuo commented Apr 21, 2025

Has the issue #513 been resolved?

@tlipoca9 The issue is not fully resolved that PP = 1 is still a current limitation. But you may deploy large model by splitting the model with purely TP, i.e. this example uses TP = 16.

@GuanLuo GuanLuo merged commit e06bfd5 into main Apr 22, 2025
6 checks passed
@GuanLuo GuanLuo deleted the gluo/multi-node-disagg branch April 22, 2025 23:20
@ishandhanani ishandhanani mentioned this pull request Apr 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@julienmancuso julienmancuso Awaiting requested review from julienmancuso julienmancuso is a code owner

@hhzhang16 hhzhang16 Awaiting requested review from hhzhang16 hhzhang16 is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia piotrm-nvidia is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@grahamking grahamking Awaiting requested review from grahamking grahamking is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@tedzhouhk tedzhouhk Awaiting requested review from tedzhouhk tedzhouhk is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

@sshchoi sshchoi Awaiting requested review from sshchoi sshchoi is a code owner

@PeaBrane PeaBrane Awaiting requested review from PeaBrane PeaBrane is a code owner

@mohammedabdulwahhab mohammedabdulwahhab Awaiting requested review from mohammedabdulwahhab mohammedabdulwahhab is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuanLuo @tlipoca9 @rmccorm4
0