8000 feat: replace dynamo server with dynamo cloud by hhzhang16 · Pull Request #696 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: replace dynamo server with dynamo cloud #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

feat: replace dynamo server with dynamo cloud #696

merged 2 commits into from
Apr 15, 2025

Conversation

hhzhang16
Copy link
Contributor
@hhzhang16 hhzhang16 commented Apr 15, 2025 •
edited
Loading

Overview:

Replace mentions of dynamo server with dynamo cloud

Details:

There has been confusion regarding the similarity between "dynamo serve" and "dynamo server", although they represent separate concepts. The Dynamo server is synonymous with the user-managed Dynamo cloud platform, so for now we will rename it to dynamo cloud and refer to it as such to avoid confusion.

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Apr 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hhzhang16 hhzhang16 requested a review from a team as a code owner April 15, 2025 21:26
@grahamking
Copy link
Contributor

@hhzhang16 Could you explain why in PR description, or attach a link to relevant doc?

julienmancuso
julienmancuso approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor
@julienmancuso julienmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hhzhang16 hhzhang16 merged commit da482c2 into main Apr 15, 2025
7 checks passed
@hhzhang16 hhzhang16 deleted the hannahz/cloud-cli-change branch April 15, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedabdulwahhab mohammedabdulwahhab mohammedabdulwahhab approved these changes

@julienmancuso julienmancuso julienmancuso approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia piotrm-nvidia is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@grahamking grahamking Awaiting requested review from grahamking grahamking is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4 rmccorm4 is a code owner

@tedzhouhk tedzhouhk Awaiting requested review from tedzhouhk tedzhouhk is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

@sshchoi sshchoi Awaiting requested review from sshchoi sshchoi is a code owner

@PeaBrane PeaBrane Awaiting requested review from PeaBrane PeaBrane is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hhzhang16 @grahamking @mohammedabdulwahhab @julienmancuso
0