8000 feat(dynamo-run): improve available engines list in --help by XueSongTap · Pull Request #664 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(dynamo-run): improve available engines list in --help #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

feat(dynamo-run): improve available engines list in --help #664

merged 1 commit into from
Apr 14, 2025

Conversation

XueSongTap
Copy link
Contributor
@XueSongTap XueSongTap commented Apr 14, 2025 •
edited by grahamking
Loading

Overview:

This PR improves the help information of the dynamo-run command line tool, optimizing the display of available engines list to make it clearer and easier to understand. This improvement will help users better understand which engine options are available, enhancing the overall user experience.

Details:

  • Reformatted the available engines list in the --help output

Where should the reviewer start?

The main changes are in the launch/dynamo-run/src/main.rs file, focusing on the sections that handle command line arguments and generate help information.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@XueSongTap
feat:improve available engines list in --help
4145ec1 
Signed-off-by: yexiaochuan <tap91624@gmail.com>
@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Apr 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions GitHub Actions
Copy link

👋 Hi XueSongTap! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Apr 14, 2025
@XueSongTap
Copy link
Contributor Author

self test:

yxc@yxc-MS-7B89:~/code/2504/dynamo/target/debug$ ./dynamo-run
USAGE: dynamo-run in=[http|text|dyn://<path>|batch:<folder>|none] out=echo_core|echo_full|mistralrs|llamacpp|sglang|vllm|pystr|pytok [--http-port 8080] [--model-path <path>] [--model-name <served-model-name>] [--model-config <hf-repo>] [--tensor-parallel-size=1] [--num-nodes=1] [--node-rank=0] [--leader-addr=127.0.0.1:9876] [--base-gpu-id=0] [--extra-engine-args=args.json] [--router-mode random|round-robin]

dynamo-run is a single binary that wires together the various inputs (http, text, network) and workers (network, engine), that runs the services. It is the simplest way to use dynamo locally.

Example:
- cargo build --release --features mistralrs,cuda
- cd target/release
- ./dynamo-run hf_checkouts/Llama-3.2-3B-Instruct/
- OR: ./dynamo-run Llama-3.2-1B-Instruct-Q4_K_M.gguf

@grahamking grahamking changed the title feat:improve available engines list in --help feat(dynamo-run): improve available engines list in --help Apr 14, 2025
@grahamking
Copy link
Contributor
grahamking commented Apr 14, 2025 •
edited
Loading

Nice work! I edited your description, AI didn't get it quite right.

@rmccorm4
Copy link
Contributor

Thanks for the contribution @XueSongTap !

@grahamking grahamking merged commit cb0ceb8 into ai-dynamo:main Apr 14, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamking grahamking grahamking approved these changes

@nnshah1 nnshah1 nnshah1 approved these changes

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

Assignees
No one assigned
Labels
external-contribution Pull request is from an external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XueSongTap @grahamking @rmccorm4 @nnshah1
0