8000 fix: dynamo build should work with link syntax by mohammedabdulwahhab · Pull Request #646 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: dynamo build should work with link syntax #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 12, 2025
Merged

fix: dynamo build should work with link syntax #646

merged 11 commits into from
Apr 12, 2025

Conversation

mohammedabdulwahhab
Copy link
Contributor
@mohammedabdulwahhab mohammedabdulwahhab commented Apr 12, 2025 •
edited
Loading

Overview:

Link syntax can remove edges between services. The manifest bento.yaml generated after running dynamo build should reflect the new service graph mutated by the link syntax.

Testing

# graphs/agg.py
from components.frontend import Frontend
from components.processor import Processor
from components.worker import VllmWorker

Frontend.link(Processor).link(VllmWorker) # graph only contains 3 components
export DYNAMO_HOME=/workspace
cd $DYNAMO_HOME/examples/llm
dynamo build graphs.agg:Frontend

Generated manifest only contains the 3 components

# $BENTOML_HOME/bentos/name/version/bento.yaml
service: graphs.agg:Frontend
name: frontend
version: me27h6yxhoauked4
services:
- name: Frontend
  service: ''
  models: []
  dependencies:
  - service: Processor
  config:
    resources:
      cpu: '10'
      memory: 20Gi
    workers: 1
    dynamo:
      enabled: false
      name: Frontend
      namespace: default
- name: Processor
  service: ''
  models: []
  dependencies:
  - service: VllmWorker
  config:
    resources:
      cpu: '10'
      memory: 20Gi
    workers: 1
    dynamo:
      enabled: true
      name: Processor
      namespace: dynamo
- name: VllmWorker
  service: ''
  models: []
  dependencies: []
  config:
    resources:
      gpu: 1
      cpu: '10'
      memory: 20Gi
    workers: 1
    dynamo:
      enabled: true
      name: VllmWorker
      namespace: dynamo

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Apr 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mohammedabdulwahhab mohammedabdulwahhab enabled auto-merge (squash) April 12, 2025 08:49
@mohammedabdulwahhab mohammedabdulwahhab enabled auto-merge (squash) April 12, 2025 09:09
@mohammedabdulwahhab
Copy link
Contributor Author
mohammedabdulwahhab commented Apr 12, 2025 •
edited
Loading

@hutm Reduced the lines we needed to bubble up from bentoml

  • removed all extraneous methods and vars from bentoml modules
  • subclassed the Bento class and overwrote the relevant method rather than in-lining the whole class

@mohammedabdulwahhab mohammedabdulwahhab self-assigned this Apr 12, 2025
@mohammedabdulwahhab mohammedabdulwahhab added the dynamo-deploy Relates to dynamo-deploy binary label Apr 12, 2025
@mohammedabdulwahhab mohammedabdulwahhab linked an issue Apr 12, 2025 that may be closed by this pull request
fix: dynamo build should work with link syntax #511
Closed
@mohammedabdulwahhab mohammedabdulwahhab merged commit 988e882 into main Apr 12, 2025
9 checks passed
@mohammedabdulwahhab mohammedabdulwahhab deleted the mabdulwahhab/fix-build branch April 12, 2025 09:34
oandreeva-nv pushed a commit that referenced this pull request Apr 22, 2025
@mohammedabdulwahhab @oandreeva-nv
fix: dynamo build should work with link syntax (#646)
7280562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutm hutm hutm approved these changes

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@julienmancuso julienmancuso Awaiting requested review from julienmancuso julienmancuso is a code owner

@hhzhang16 hhzhang16 Awaiting requested review from hhzhang16 hhzhang16 is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

Assignees

@mohammedabdulwahhab mohammedabdulwahhab

Labels
dynamo-deploy Relates to dynamo-deploy binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: dynamo build should work with link syntax
2 participants
@mohammedabdulwahhab @hutm
0