fix: serviceArgs in config was not getting set for workers #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
ServiceArgs portion of
DYNAMO_SERVICE_CONFIG
will always be empty from the POV of workers due to this line. This MR fixes this issue.Then why does setting
gpus
orworkers
in the config file currently work (e.g here)? Workers and gpus are attributes consumed and processed by the top level program. They aren't consumed at all in the subprocesses. At the top level program these attributes are available and okay. However, any attributes that need to be consumed at the subprocess level will simply not be present.Testing
Tested: