8000 docs: Guide for multi-node benchmarking by kthui · Pull Request #561 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: Guide for multi-node benchmarking #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 11, 2025
Merged

docs: Guide for multi-node benchmarking #561

merged 8 commits into from
Apr 11, 2025

Conversation

kthui
Copy link
Contributor
@kthui kthui commented Apr 9, 2025 •
edited
Loading

Overview:

Add multi-node instruction to the benchmarking guide.

Details:

Previous comments to be addressed:

Where should the reviewer start?

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Apr 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kthui kthui self-assigned this Apr 9, 2025
@kthui kthui mentioned this pull request Apr 9, 2025
Merged
@kthui kthui changed the title Jacky benchmarking guide multi node docs: Guide for multi-node benchmarking Apr 9, 2025
@kthui kthui force-pushed the jacky-benchmarking-guide-multi-node branch from 59536e3 to e83e123 Compare April 10, 2025 01:00
@kthui kthui marked this pull request as ready for review April 10, 2025 22:36
@kthui kthui requested review from mohammedabdulwahhab and a team as code owners April 10, 2025 22:36
@kthui kthui enabled auto-merge (squash) April 10, 2025 22:48
nnshah1
nnshah1 reviewed Apr 10, 2025
View reviewed changes
nnshah1
nnshah1 reviewed Apr 10, 2025 10000
View reviewed changes
nnshah1
nnshah1 reviewed Apr 11, 2025
View reviewed changes
kthui and others added 2 commits April 10, 2025 17:44
@kthui @nnshah1
Update examples/llm/benchmarks/README.md
2c897d9 
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
@kthui
Fix network docs GitHub view
7225a24
@saturley-hall saturley-hall force-pushed the jacky-benchmarking-guide-multi-node branch from 7225a24 to 2c897d9 Compare April 11, 2025 01:01
@kthui kthui requested a review from nnshah1 April 11, 2025 01:21
@nvda-mesharma nvda-mesharma disabled auto-merge April 11, 2025 01:24
@nvda-mesharma nvda-mesharma merged commit b2f2939 into main Apr 11, 2025
5 checks passed
@nvda-mesharma nvda-mesharma deleted the jacky-benchmarking-guide-multi-node branch April 11, 2025 01:24
nv-anants pushed a commit that referenced this pull request Apr 11, 2025
@kthui @nnshah1
@nvda-mesharma @nv-anants
docs: Guide for multi-node benchmarking (#561)
8f77280 
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Co-authored-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
nvda-mesharma added a commit that referenced this pull request Apr 11, 2025
@nv-anants @kthui
@nnshah1 @nvda-mesharma
docs: Guide for multi-node benchmarking (#561) (#618)
3f2c4d6 
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
Co-authored-by: Jacky <18255193+kthui@users.noreply.github.com>
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Co-authored-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
saturley-hall pushed a commit that referenced this pull request Apr 11, 2025
@nv-anants @kthui
@nnshah1 @nvda-mesharma
docs: Guide for multi-node benchmarking (#561) (#618)
a8b30ec 
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
Co-authored-by: Jacky <18255193+kthui@users.noreply.github.com>
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Co-authored-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
@kthui @nnshah1 @nvda-mesharma
docs: Guide for multi-node benchmarking (ai-dynamo#561)
538b463 
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Co-authored-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
oandreeva-nv pushed a commit that referenced this pull request Apr 22, 2025
@kthui @nnshah1
@nvda-mesharma @oandreeva-nv
docs: Guide for multi-node benchmarking (#561)
ebfcec2 
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
Co-authored-by: Neelay Shah <neelays@nvidia.com>
Co-authored-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnshah1 nnshah1 nnshah1 approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@julienmancuso julienmancuso Awaiting requested review from julienmancuso julienmancuso is a code owner

@hhzhang16 hhzhang16 Awaiting requested review from hhzhang16 hhzhang16 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia piotrm-nvidia is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@ryanolson ryanolson Awaiting requested review from ryanolson ryanolson is a code owner

@grahamking grahamking Awaiting requested review from grahamking grahamking is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4 rmccorm4 is a code owner

@tedzhouhk tedzhouhk Awaiting requested review from tedzhouhk tedzhouhk is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

@sshchoi sshchoi Awaiting requested review from sshchoi sshchoi is a code owner

@PeaBrane PeaBrane Awaiting requested review from PeaBrane PeaBrane is a code owner

@mohammedabdulwahhab mohammedabdulwahhab Awaiting requested review from mohammedabdulwahhab mohammedabdulwahhab is a code owner

Assignees

@kthui kthui

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kthui @nnshah1 @nvda-mesharma
0