chore: Upgrade Rust to 1.86 #518
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-anants
reviewed
Apr 4, 2025
There was a problem hiding this comment.
LGTM! one more reference here - https://github.com/ai-dynamo/dynamo/blob/main/.github/workflows/pre-merge-rust.yml#L69
Nice catch! |
nv-anants
approved these changes
Apr 4, 2025
dmitry-tokarev-nv
approved these changes
Apr 4, 2025
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
Also upgrade the cargo resolver to v3, the default. New clippy lints: - `next_back()` instead of `last()` for a double-ended iterator. That avoids walking the whole list. - ` repeat_n` instead of `repeat.take`. That avoids cloning. - Doc indenting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade the cargo resolver to v3, the default.
New clippy lints:
next_back()instead oflast()for a double-ended iterator. That avoids walking the whole list.repeat_ninstead ofrepeat.take. That avoids cloning.