8000 docs: add copy dynamo-run by hanweisen · Pull Request #508 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add copy dynamo-run #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

docs: add copy dynamo-run #508

merged 1 commit into from
Apr 3, 2025

Conversation

hanweisen
Copy link
Contributor

Overview:

Improve documentation, resolve executing 'dynamo run out=vllm deepseek-ai/DeepSeek-R1-Distill-Llama-8B' in Local Development reports 'dynamo-run not found'

Details:

After completing the operations guided in Local Development, executing 'dynamo run out=vllm deepseek-ai/DeepSeek-R1-Distill-Llama-8B' results in the following error:

root@ecs-28633845:/workspace# dynamo run out=vllm deepseek-ai/DeepSeek-R1-Distill-Llama-8B                                                                                        
Traceback (most recent call last):                                                       
  File "/opt/dynamo/venv/bin/dynamo-run", line 10, in <module>                                                                                                                    
    sys.exit(dynamo_run())                                                               
             ^^^^^^^^^^^^                                                                
  File "/workspace/deploy/dynamo/sdk/src/dynamo/sdk/cli/run_executable.py", line 68, in dynamo_run                                                                                
    result = run_executable("dynamo-run", args=args, capture_output=False)                                                                                                        
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                        
  File "/workspace/deploy/dynamo/sdk/src/dynamo/sdk/cli/run_executable.py", line 42, in run_executable                                                                            
    raise FileNotFoundError(                                                             
FileNotFoundError: Executable 'dynamo-run' not found in /workspace/deploy/dynamo/sdk/src/dynamo/sdk/cli/bin                                                                       
root@ecs-28633845:/workspace# which dynamo                                                                                                                                        
/opt/dynamo/venv/bin/dynamo                                                              
root@ecs-28633845:/workspace# which dynamo-run                                                                                                                                    
/opt/dynamo/venv/bin/dynamo-run                                                          
root@ecs-28633845:/workspace# /opt/dynamo/venv/bin/dynamo-run                                                                                                                     
Traceback (most recent call last):                                                       
  File "/opt/dynamo/venv/bin/dynamo-run", line 10, in <module>                                                                                                                    
    sys.exit(dynamo_run())                                                               
             ^^^^^^^^^^^^                                                                
  File "/workspace/deploy/dynamo/sdk/src/dynamo/sdk/cli/run_executable.py", line 68, in dynamo_run                                                                                
    result = run_executable("dynamo-run", args=args, capture_output=False)                                                                                                        
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                        
  File "/workspace/deploy/dynamo/sdk/src/dynamo/sdk/cli/run_executable.py", line 42, in run_executable                                                                            
    raise FileNotFoundError(                                                             
FileNotFoundError: Executable 'dynamo-run' not found in /workspace/deploy/dynamo/sdk/src/dynamo/sdk/cli/bin

Where should the reviewer start?

@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Apr 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 3, 2025

👋 Hi hanweisen! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Apr 3, 2025
@hanweisen hanweisen force-pushed the docs-cp-dynamo-run branch 2 times, most recently from fb2dcd1 to 01c0a73 Compare April 3, 2025 14:30
@hanweisen hanweisen force-pushed the docs-cp-dynamo-run branch from ce02acc to 01c0a73 Compare April 3, 2025 15:36
@hanweisen
docs: add copy dynamo-run
26cd87a 
Signed-off-by: hanweisen <hanweisen_yewu@cmss.chinamobile.com>
@hanweisen hanweisen force-pushed the docs-cp-dynamo-run branch from 01c0a73 to 26cd87a Compare April 3, 2025 15:36
@grahamking grahamking enabled auto-merge (squash) April 3, 2025 15:57
@grahamking grahamking merged commit 553b90c into ai-dynamo:main Apr 3, 2025
5 checks passed
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
@hanweisen
docs: add instruction to copy dynamo-run in container setup (ai-dynam…
e38e5ab 
…o#508)

Signed-off-by: hanweisen <hanweisen_yewu@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamking grahamking grahamking approved these changes

Assignees
No one assigned
Labels
external-contribution Pull request is from an external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanweisen @grahamking
0