8000 refactor: migrate engines to standalone crates by ryanolson · Pull Request #453 · ai-dynamo/dynamo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: migrate engines to standalone crates #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 3, 2025
Merged

refactor: migrate engines to standalone crates #453

merged 12 commits into from
Apr 3, 2025

Conversation

ryanolson
Copy link
Contributor
@ryanolson ryanolson commented Mar 31, 2025 •
edited by grahamking
Loading

Moved all of lib/llm/src/engines to their own crates as e.g. lib/engines/mistralrs. This will allow publishing of the dynamo-llm crate as it won't have any github dependencies.

The only engines in dynamo-llm will be the demo echo ones.

@grahamking grahamking force-pushed the ryan/engine-refactor branch from e276dc0 to 70f1f14 Compare April 3, 2025 13:17
@grahamking
Copy link
Contributor

This should help CI: #507

@grahamking grahamking force-pushed the ryan/engine-refactor branch from f502e69 to c330004 Compare April 3, 2025 14:46
@grahamking grahamking changed the title refactor: migrate llamacpp to standalone crate refactor: migrate engines to standalone crates Apr 3, 2025
@grahamking grahamking force-pushed the ryan/engine-refactor branch from 9344077 to 461bc02 Compare April 3, 2025 20:48
@grahamking grahamking marked this pull request as ready for review April 3, 2025 20:49
@grahamking grahamking enabled auto-merge (squash) April 3, 2025 21:35
@grahamking grahamking merged commit ce68339 into main Apr 3, 2025
10 of 11 checks passed
@grahamking grahamking deleted the ryan/engine-refactor branch April 3, 2025 21:53
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
@ryanolson @grahamking
refactor: migrate engines to standalone crates (ai-dynamo#453)
84985d3 
Moved all of `lib/llm/src/engines` to their own crates as e.g. `lib/engines/mistralrs`. This will allow publishing of the `dynamo-llm` crate as it won't have any github dependencies.

The only engines in dynamo-llm will be the demo `echo` ones.

Co-authored-by: Graham King <grahamk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamking grahamking grahamking approved these changes

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia piotrm-nvidia is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@paulhendricks paulhendricks Awaiting requested review from paulhendricks paulhendricks is a code owner

@biswapanda biswapanda Awaiting requested review from biswapanda biswapanda is a code owner

@tmonty12 tmonty12 Awaiting requested review from tmonty12 tmonty12 is a code owner

@GuanLuo GuanLuo Awaiting requested review from GuanLuo GuanLuo is a code owner

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4 rmccorm4 is a code owner

@tedzhouhk tedzhouhk Awaiting requested review from tedzhouhk tedzhouhk is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@kkranen kkranen Awaiting requested review from kkranen kkranen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanolson @grahamking
0