8000 fix indentation for yaml by rajatjindal · Pull Request #8 · ahmetb/kubectl-foreach · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix indentation for yaml #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2022
Merged

fix indentation for yaml #8

merged 2 commits into from
Aug 31, 2022

Conversation

rajatjindal
Copy link
Contributor
@rajatjindal rajatjindal commented Aug 30, 2022 •
edited
Loading

Hi Ahmet,

thanks for reporting the issue. I looked at it and it seems like an indentation issue.

if you notice {{ addURIAndSha ...}} in the original yaml is indented with 6 spaces. by default krew-release-bot indent with 4 spaces.

if we indeed want 6 spaces, then we can use following:

{{addURIAndSha ...... | indent 6 }}

this was added for similar issue rajatjindal/krew-release-bot#25

@ahmetb
Copy link
Owner
ahmetb commented Aug 30, 2022

I have more changes in kubernetes-sigs/krew-index#2554, might be worth just getting it from krew-index instead and put the template in.

@rajatjindal
Copy link
Contributor Author

hi Ahmet,

updated the template from krew-index repo.

thanks
Rajat Jindal

@ahmetb ahmetb merged commit 4ac672d into ahmetb:master Aug 31, 2022
@ahmetb
Copy link
Owner
ahmetb commented Aug 31, 2022

Thank you. 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajatjindal @ahmetb
0