Audio file reading with resampling + windows clang recommendation #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio files can be read with support for resampling. Changed to clang64 as the recommended toolchain on windows for asan/ubsan support. Updated docs and added some info about sanitizers.
ahihi
reviewed
May 28, 2025
ahihi
reviewed
May 28, 2025
ahihi
reviewed
May 28, 2025
|
addressed the issues! |
ahihi
reviewed
Jun 5, 2025
| #include "SoundFiles.hpp" | ||
|
|
||
| using Resampler = r8b::CDSPResampler; | ||
| using namespace std; |
There was a problem hiding this comment.
i think it would be better to avoid this, as std is a big namespace. consider using specific members, or just write out the std:: :) (i tend to prefer the latter for clarity)
|
aside from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio files can be read with support for resampling using the
>sfoperation. Changed to clang64 as the recommended toolchain on windows for asan/ubsan support. Updated docs and added some info about sanitizers.The r8brain library handles the actual core resampling logic and is included as a git submodule.
Completes #2