8000 add O_DIRECTORY to fs.constants by hajimehoshi · Pull Request #71 · agnivade/wasmbrowsertest · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add O_DIRECTORY to fs.constants #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

add O_DIRECTORY to fs.constants #71

merged 1 commit into from
Jan 31, 2025

Conversation

hajimehoshi
Copy link
Contributor

Fixes #70

@hajimehoshi
Copy link
Contributor Author

I think we need to disable apparmor.

See also: https://github.com/hajimehoshi/ebiten/blob/c9d3b98b8067f8cdd4f1236e5530bf14e9c92d6f/.github/workflows/test.yml#L175

@agnivade
Copy link
Owner

Yeah, good one. Please feel free to go ahead and update the yaml file.
8000

@hajimehoshi
Copy link
Contributor Author

I've created a separate PR #72

@hajimehoshi
Copy link
Contributor Author

I've rebased this PR. Please take a look

@hajimehoshi
Copy link
Contributor Author

main_test.go:98: Unexpected error message: "exit with status 2" != "websocket url timeout reached"

This seems just a time out.

@agnivade
Copy link
Owner

It is that same flaky test which never really went away. I restarted the test. If it fails again, I'll just rip off the test for good. It's too much pain.

@hajimehoshi
Copy link
Contributor Author

As this is a fix for a critical issue for Go 1.24, can we merge this first? I believe retyring the test should work in the current situation.

@agnivade
Copy link
Owner

Yeah, I did retry. It passed. Going to merge it now. Thanks for the reminder. I should also send a PR to rip that test off.

@agnivade agnivade merged commit 5e0f0b9 into agnivade:master Jan 31, 2025
4 of 6 checks passed
@hajimehoshi hajimehoshi deleted the directory branch January 31, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test fails with Go 1.24 rc2 for Ebitengine
2 participants
@hajimehoshi @agnivade
0