Add query params for GET requests and body json params for POST requests #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add params handling for GET requests - Add json handling for POST requests - Add test cases for request options
There was a problem hiding this comment.
PR Summary
This PR adds proper parameter handling for HTTP requests in the ReqAction module, implementing query parameters for GET requests and JSON body parameters for POST requests.
- Added conditional parameter handling in
make_requestto use:paramsfor GET and:jsonfor POST/PUT requests - Added
SimplePosttest module to verify POST request functionality - Added test coverage for query parameter handling in GET requests
- Added test coverage for JSON body parameter handling in POST requests
- Improved request option building with proper parameter placement based on HTTP method
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.