Some documentation fixes #7065
Merged
Some documentation fixes #7065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad I could contribute with something! 😄 |
andreasabel
pushed a commit
that referenced
this pull request
Feb 8, 2024
* documentation fixes `lexical-structure` * documentation fixes `built-ins` * misc typos * add remark about chesion * update `safe-agda` * add vscode workspace settings * double tick `as` * review
andreasabel
added a commit
that referenced
this pull request
Feb 13, 2024
VitalyAnkh
pushed a commit
to VitalyAnkh/agda
that referenced
this pull request
Mar 5, 2024
* documentation fixes `lexical-structure` * documentation fixes `built-ins` * misc typos * add remark about chesion * update `safe-agda` * add vscode workspace settings * double tick `as` * review
VitalyAnkh
pushed a commit
to VitalyAnkh/agda
that referenced
this pull request
Mar 5, 2024
JobPetrovcic
pushed a commit
to JobPetrovcic/agda
that referenced
this pull request
Apr 12, 2024
* documentation fixes `lexical-structure` * documentation fixes `built-ins` * misc typos * add remark about chesion * update `safe-agda` * add vscode workspace settings * double tick `as` * review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--cohesionnot including the full set-up for cohesive homotopy type theorySetis not a reserved keywordopaqueandunfoldingare reserved keywordsashas special meaning inimportstatementsdoc/user-manual/language/safe-agdato be accurate and complete, based onunsafePragmaOptionsand discussion I could find.doc/user-manual/language/built-ins, and remark onLevelUniv.Remarks / Questions
.vscode/settings.jsonwas added to.gitignoreunder the justification that the repository should not hold user settings, but this file is meant for repository-wide settings that help homogenize the contribution experience. For instance, the documentation seems to have a working line character limit of about 80 characters. This file allows you to add settings gently informing contributors about this with the settingdoc/user-manual/language/safe-agdaleaves some justification missing. I would for instance love to know why--flat-splittogether with--without-Kis disallowed. All the discussion I could find seemed to be about cubical. Also, I don't know what's up with--sized-types.Apologies in advance if any of the changes are unwelcome!