Delete unused glue1 bindings
#7021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why comment rather than delete? |
Since Kan operations in Glue types are evaluated negatively, we're not using `glue` at all. Also clarify the comment explaining this in `headStop`.
glue1 bindingsglue1 bindings
|
Just in case we ever decide to remove the optimisation, though I guess it's not hard to go back in git history. |
andreasabel
pushed a commit
that referenced
this pull request
Feb 8, 2024
Since Kan operations in Glue types are evaluated negatively, we're not using `glue` at all. Also clarify the comment explaining this in `headStop`.
JobPetrovcic
pushed a commit
to JobPetrovcic/agda
that referenced
this pull request
Apr 12, 2024
Since Kan operations in Glue types are evaluated negatively, we're not using `glue` at all. Also clarify the comment explaining this in `headStop`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Kan operations in Glue types are evaluated negatively, we're not using
glueat all.Also clarify the comment explaining this in
headStop.