Fix {modify,state}TCLensM and %== and %%= (lost state effects)
#7474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
andreasabel
added
the
type: task
Concerning the development of Agda (not in changelog)
label
Sep 6, 2024
andreasabel
commented
Sep 6, 2024
There was a problem hiding this comment.
@jespercockx Was the following code exploiting a buggy implementation of stateTCLensM?
agda/src/full/Agda/TypeChecking/Monad/Base.hs
Lines 990 to 991 in 0be54d7
I suppose not, because it is only used in the following two methods which are only used in AbstractToConcrete:
agda/src/full/Agda/TypeChecking/Monad/Base.hs
Lines 984 to 988 in 0be54d7
| @@ -786,7 +786,7 @@ solveAwakeConstraints' = solveSomeAwakeConstraints (const True) | |||
| {-# SPECIALIZE freezeMetas :: LocalMetaStore -> TCM (Set MetaId) #-} | |||
| -- | Freeze the given meta-variables (but only if they are open) and | |||
| -- return those that were not already frozen. | |||
| freezeMetas :: forall m. MonadTCState m => LocalMetaStore -> m (Set MetaId) | |||
| freezeMetas :: forall m. (MonadTCState m, ReadTCState m) => LocalMetaStore -> m (Set MetaId) | |||
| freezeMetas ms = | |||
| execWriterT $ | |||
| modifyTCLensM stOpenMetaStore $ | |||
There was a problem hiding this comment.
This use of modifyTCLensM was fine even before the fix because the computation did not modify TCState.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #7470 (comment)