8000 #6958: Clarify documentation by plt-amy · Pull Request #6982 · agda/agda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#6958: Clarify documentation #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2023
Merged

#6958: Clarify documentation #6982

merged 1 commit into from
Nov 12, 2023

Conversation

plt-amy
Copy link
Member
@plt-amy plt-amy commented Nov 10, 2023

Marking a primitive opaque did not have an effect before, and Agda will now warn if you try it, so I removed the sentence from the docs per @nad's suggestion. However I have not yet excised the opacity field from primitives, since I believe the IsAbstract field should be removed too, and I'd prefer to do that in one PR.

@plt-amy plt-amy added ux: documentation Issues relating to Agda's documentation not-in-changelog This issue should not be listed in the changelog. labels Nov 10, 2023
@plt-amy plt-amy self-assigned this Nov 10, 2023
Copy link
Member
@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andreasabel andreasabel added the opaque Issues about `opaque` definitions label Nov 11, 2023
@andreasabel andreasabel added this to the 2.6.4.1 milestone Nov 11, 2023
@andreasabel
Copy link
Member

@plt-amy : You are assigned, do you want to merge it yourself?

@plt-amy plt-amy merged commit 32ffb36 into master Nov 12, 2023
@plt-amy plt-amy deleted the aliao/issue-6958-docs branch November 12, 2023 17:33
@andreasabel
Copy link
Member

Thanks!

JobPetrovcic pushed a commit to JobPetrovcic/agda that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog This issue should not be listed in the changelog. opaque Issues about `opaque` definitions ux: documentation Issues relating to Agda's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0