feat: Add AsyncAPI HTTP Support #2142
Conversation
|
Hi @Lancetnik can you review please? |
|
|
|
@tmulligan98 sorry, missed this one! I definitely check check soon |
Done 😃 |
There was a problem hiding this comment.
Sorry for waiting so long
Great job! Really appreciate the help. But, I think, we should make some more extensive changes – migrate ASGI functions to classes to incapsulate some logic to them and make them able to store metainforamation
Also, we should polish the types to remove all mypy ignores (if it is possilbe)
docs/docs/en/release.md
Outdated
There was a problem hiding this comment.
Please, remove this file changes
Not sure. Looks enough for me. |
| for route in app.routes: | ||
| path, asgi_app = route | ||
|
|
||
| if asgi_app.include_in_schema: |
There was a problem hiding this comment.
We should check is this object a GetHandler instance. User could be able to add own ASGI handler to router
|
Well, thank you! I think, it is good enough. I want to polish some things by myself and then we can merge the PR |
Description
Add support for an
include_in_schemaparameter to register HTTP routes in the app schemaTODO: Should
include_in_schemabeTrueby default?Fixes #2091
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh