Fix quote creation for manual symbols #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that an activity is created or updated before a corresponding quote is generated, preserving proper asset existence for manual symbols.
- The add activity mutation now creates the activity first then creates the quote.
- The update activity mutation follows a similar order change.
Comments suppressed due to low confidence (2)
src/pages/activity/hooks/use-activity-mutations.ts:80
- In the add activity mutation, if createQuoteFromActivity fails after the activity has been created, consider implementing error handling or a rollback mechanism to maintain data consistency.
const activity = await createActivity(rest);
src/pages/activity/hooks/use-activity-mutations.ts:89
- For the update activity mutation, ensure there is a strategy to handle failures in createQuoteFromActivity after updating the activity, to keep the activity and quote data in sync.
const activity = await updateActivity(data);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm testhttps://chatgpt.com/codex/tasks/task_e_68547bbfff048324accce31a3d713663