Voting improvements #4555
Merged
Voting improvements #4555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happi
previously approved these changes
Feb 25, 2025
happi
approved these changes
Feb 25, 2025
richcarl
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It started as trying to remove the
trunc(math:ceil(...))computation, but turned into actually fixing voting. It only worked when you had three stakers with exactly the same stake... Once rewards kicked in it started failing. Logic does not properly handle implicit leader stake, nor the case (that we have in testing) when two validators run on the same node.This PR is supported by Æternity foundation.