8000 Add validator docs by dincho · Pull Request #4538 · aeternity/aeternity · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add validator docs #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 3, 2025
Merged

Add validator docs #4538

merged 13 commits into from
Feb 3, 2025

Conversation

dincho
Copy link
Member
@dincho dincho commented Jan 30, 2025

No description provided.

klercker
klercker previously approved these changes Jan 30, 2025
hanssv
hanssv previously approved these changes Jan 30, 2025
Copy link
Member
@hanssv hanssv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible!

Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
@dincho dincho dismissed stale reviews from hanssv and klercker via 53d8d13 January 31, 2025 09:15
dincho and others added 9 commits January 31, 2025 11:15
Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
@
8000
dincho
Copy link
Member Author
dincho commented Jan 31, 2025

Thanks you very much @davidyuk for the CLI fixes

Copy link
Contributor
@ploetzly ploetzly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your addition of validator documentation. I've made suggestions to improve grammar, clarity, and moved some warnings sooner in the text than they are now. Soome text suggestions are explanatory so may be more appropriate for a more finalized version of this documentation.

@dincho
Copy link
Member Author
dincho commented Jan 31, 2025

thanks for your addition of validator documentation. I've made suggestions to improve grammar, clarity, and moved some warnings sooner in the text than they are now. Soome text suggestions are explanatory so may be more appropriate for a more finalized version of this documentation.

All suggestions applied in 3e7fc125b

@dincho dincho merged commit 94f525e into master Feb 3, 2025
42 checks passed
@dincho dincho deleted the add_validator_docs branch February 3, 2025 10:06
@dincho
Copy link
Member Author
dincho commented Feb 3, 2025

Thank you all for the reviews

mitchelli pushed a commit that referenced this pull request Feb 13, 2025
* Fix headings levels of hyperchains.md

* Document how to add new validator to a Hyperchain

---------

Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>
@dincho dincho added kind/feature Issues or PRs related to a new feature area/docs Issues or PRs related to documentation labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Issues or PRs related to documentation kind/feature Issues or PRs related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0