Add comments to aec_block_generator #4529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klercker
approved these changes
Jan 20, 2025
mitchelli
approved these changes
Jan 20, 2025
hanssv
requested changes
Jan 21, 2025
| case aec_blocks:txs(Candidate) of | ||
| [] -> | ||
| lager:debug("New empty microblock candidate generated, and discarded", []), | ||
| lager:debug("Empty microblock candidate prepared", []), |
There was a problem hiding this comment.
discarded was the important bit here, I don't like it being removed from the message.
There was a problem hiding this comment.
I was trying to find a wording that made sense. It's not discarded, just not published, and stays in the state ready to be filled when there are incoming tx events. Any better suggestion?
| ok; | ||
| _ -> | ||
| epoch_mining:info("New microblock candidate generated", []), | ||
| epoch_mining:info("New microblock candidate ready", []), |
There was a problem hiding this comment.
Well, it's getting published as being ready to fetch. Tried to make it contrast with the alternative message above
hanssv
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.