Make logdir configuration work as intended #4491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a87550 to
50ff9d9
Compare
50ff9d9 to
e2a1b43
Compare
|
build and run setup is beyond my expertise in so many ways, but are there any reasons we could not get this one out of the way? |
|
There were still some complications as I recall, and it wasn't a high priority. But it would be nice to do because this blocked other things we wanted to fix with logging when running under Docker. |
e2a1b43 to
361d461
Compare
klercker
approved these changes
Feb 16, 2025
happi
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logdir configuration is defined in
setuppart of the sys.config, just like the data dir, but it did not work as intended because lager wants to create the log directory on disk as soon as it starts, and at that point it will have its own default config settings. This fixes the problem and switches the start order of setup and lager.Depends on #4496.
This PR is supported by Æternity Foundation.