Pinning Agent refactor to new_epoch event
#4499
Conversation
new_epocheventnew_epoch event
4cea060 to
853f616
Compare
|
The |
Yes, naming looks updated and correct, the drawback of spawning yet another process is that you need to register for events every time, etc. It is much cleaner and not a lot of work to just put that logic directly in the gen_server. |
|
As per "advice" from @richcarl and @happi and others I put it in a separate worker process and I like the look of it (and I really don't like the look of If it's very very important to you @hanssv, I will refac again, but I really do like the current impl and it's not particularly non-standard. |
|
If Richard and Happi with a straight face will claim that this implementation is superior I will consider to change my mind. |
|
Not superior perhaps, but valid 😅 |
| #{caller_id => aeser_id:create(account, Who) | ||
| , nonce => Nonce |
There was a problem hiding this comment.
Fix: Space after the curly, and comma aligns with curly...
Move pinning agent invocation code from inner consensus callbacks to separate gen_server+worker process.
This PR is supported by Æternity Foundation