More robust caching of validator schedules #4461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasArts
reviewed
Oct 29, 2024
| @@ -362,13 +360,6 @@ contract_call(ContractPubkey, Src, Fun, Args, Amount, From, Nonce) -> | |||
| {ok, Tx} = aect_call_tx:new(TxSpec), | |||
| Tx. | |||
|
|
|||
| %% This test is trivially true, since we already check in | |||
| %% sync when producting the blocks. | |||
| mine_and_sync(Config) -> | |||
There was a problem hiding this comment.
Perfectly fine to remove obsolete test
ThomasArts
approved these changes
Oct 29, 2024
Comment on lines
+483
to
+484
| %% We buffer the seed two epochs | ||
| ParentHeight = rpc(?NODE1, aec_consensus_hc, entropy_height, [Epoch]), |
There was a problem hiding this comment.
Much nicer now with aligned logic
happi
approved these changes
Oct 30, 2024
| case Height == maps:get(last, EpochInfo) of | ||
| true -> | ||
| {ok, Seed} = get_entropy_hash(Epoch + 1), | ||
| {ok, Seed} = get_entropy_hash(Epoch + 2), |
There was a problem hiding this comment.
Possibly document the "random" +2 used here ;).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main observation, at the point where we call
step_eoewe know the seed/hash (and thus in effect the schedule) for next-next Epoch. No point in not caching that schedule right away.Second issue is bootstrapping after restart, that should be handled by the current code, but there are no tests for it.
This PR also adds a test that puts microblocks in all positions in an epoch.
Finally it aligns
entropy_heightwith the Whitepaper.Fixes #4458.
This PR is supported by Æternity Foundation.