10000 Multiple epochs in contract by ThomasArts · Pull Request #4421 · aeternity/aeternity · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Multiple epochs in contract #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 23, 2024
Merged

Multiple epochs in contract #4421

merged 12 commits into from
Sep 23, 2024

Conversation

ThomasArts
Copy link
Contributor

Extended the contract to keep track of the four cycles, i.e. four epochs.

Added aec_chain_hc as interface module (good for testing)
Added additional tests

This PR is supported by Æternity Foundation

klercker
klercker previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor
@klercker klercker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I like the chain libraries esp. Now just an awesome test harness for multi chain setups and we're good to go!

@ThomasArts
Copy link
Contributor Author

Looking good, I like the chain libraries esp. Now just an awesome test harness for multi chain setups and we're good to go!

I would argue that aehttp_hyperchain_SUITE is exactly that test harness you are out after... but I need to add more tests, of course.

@hanssv hanssv merged commit 90144d2 into master Sep 23, 2024
40 checks passed
@hanssv hanssv deleted the multiple_epochs_in_contract branch September 23, 2024 05:47
@dincho dincho added the kind/feature Issues or PRs related to a new feature label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanssv hanssv hanssv approved these changes

@klercker klercker klercker approved these changes

Assignees
No one assigned
Labels
area/hyperchains kind/feature Issues or PRs related to a new feature
Projects
Periodically Syncing Hyperchains
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThomasArts @hanssv @klercker @happi @dincho
0