8000 Added initial version of hacking guide by richcarl · Pull Request #4398 · aeternity/aeternity · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added initial version of hacking guide #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Added initial version of hacking guide #4398

merged 1 commit into from
Sep 4, 2024

Conversation

richcarl
Copy link
Contributor
@richcarl richcarl commented Sep 3, 2024

An overview of the codebase to help programmers.

hanssv
hanssv reviewed Sep 3, 2024
View reviewed changes
@richcarl richcarl requested review from happi and klercker September 4, 2024 07:41
@richcarl
Copy link
Contributor Author
richcarl commented Sep 4, 2024

Can I get a couple of approvals so I can merge this? Then we can all help adding and modifying.

dincho
dincho approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member
@dincho dincho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bits on the relx and rebar3 seems to be outdated, we have copied and modified(?) some of the relx binaries/scripts I think.

@richcarl
Copy link
Contributor Author
richcarl commented Sep 4, 2024

The bits on the relx and rebar3 seems to be outdated, we have copied and modified(?) some of the relx binaries/scripts I think.

Let's investigate that and update the doc later in that case.

@dincho
Copy link
Member
dincho commented Sep 4, 2024

The bits on the relx and rebar3 seems to be outdated, we have copied and modified(?) some of the relx binaries/scripts I think.

Let's investigate that and update the doc later in that case.

While I did approved this PR, it doesn't make sense in general to commit an outdated info into master

@hanssv
Copy link
Member
hanssv commented Sep 4, 2024

Wouldn't this info fit better in the wiki? Though that is probably even more outdated.

@richcarl richcarl merged commit 8414978 into master Sep 4, 2024
40 checks passed
@richcarl 7CD9 richcarl deleted the hacking-docs branch September 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanssv hanssv hanssv approved these changes

@dincho dincho dincho approved these changes

@happi happi Awaiting requested review from happi

@klercker klercker Awaiting requested review from klercker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richcarl @dincho @hanssv
0