Fix rollback and direct access issue #4378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dincho
approved these changes
Jul 9, 2024
mitchelli
approved these changes
Jul 11, 2024
mitchelli
pushed a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4376 for manifestation. This fixes #4376.
The problem is not related to dev_mode, rather it is an issue when using direct DB access. There was a direct call to
mnesia:deletein the logic for removing a transaction (used by rollback) - this broke when the system expected direct access. The fix is trivial. In the best of worlds we should have tests finding this (the devmode rollback tests expose the issue - if run with rocksdb and persistence, but normally they are not).This PR is supported by Æternity Foundation.