Load contracts from default directories #4322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanssv
previously approved these changes
Apr 8, 2024
| @@ -344,7 +348,15 @@ extra_accounts_json_file() -> | |||
| "extra_accounts_test.json". | |||
|
|
|||
| contracts_json_file() -> | |||
There was a problem hiding this comment.
Isn't this just a subset of the function below? I can't remember why we wan't the TEST one?
There was a problem hiding this comment.
This filename is a legacy one ... back then one could only set accounts (and later contracts) via this file. The suffix "_test" I believe comes from the original usage for tests only, but at some point all "custom" network ID's has been using this.
There was a problem hiding this comment.
Ah, I see what your comment is about now .. nvm
There was a problem hiding this comment.
I've moved the functions out of test and made a generic function for creating the file name.
hanssv
approved these changes
Apr 8, 2024
ThomasArts
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4320
This PR is supported by Æternity Foundation