[Ceres] Make NamePreclaim optional #4201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwiger
approved these changes
Sep 5, 2023
Comment on lines
+623
to
+626
| State = case proplists:get_value(state, Cfg) of | ||
| undefined -> aens_test_utils:new_state(); | ||
| State0 -> State0 | ||
| end, |
There was a problem hiding this comment.
Seems like this could be factored out into a helper function.
mitchelli
pushed a commit
that referenced
this pull request
Jan 22, 2024
* [Ceres] Add logic to allow skipping NamePreclaim * Tests for preclaim-free nameclaim * Added a release note * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4174
Make NamePreclaimTx optional. Since the introduction of auctions, the front-running protection offered by the 'PreClaim -> Claim' flow is no longer as important. To simplify name registrations (or the start of a name auction) we now allow NameClaimTx without a previous NamePreclaimTx. In this case we set the
NameSaltto0.This PR is supported by the Æternity Crypto Foundation