8000 Fix typos, style and toc by btriller · Pull Request #355 · aerleon/aerleon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typos, style and toc #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 25, 2025
Merged

Fix typos, style and toc #355

merged 7 commits into from
May 25, 2025

Conversation

btriller
Copy link
Contributor
@btriller btriller commented Oct 31, 2023 •
edited
Loading
  • Fix some typos, style and NSXt/v docs.
  • Drop some generated sample policies.
  • This also fixes missing generator links in TOC

ankenyr
ankenyr reviewed Nov 3, 2023
View reviewed changes
docs/reference/generators.md
@@ -1148,62 +1145,42 @@ targets:

***

# NSXT
## NSXt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most cases I see have all letters capitalized. https://www.vmware.com/products/nsx/migrate-to-nsx-t.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Do you mind a dash between NSX and T/v?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind a dash in documentation and comments. Don't change any modules, classes, or method names.

@ankenyr ankenyr merged commit 69eaa58 into aerleon:main May 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankenyr ankenyr ankenyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
35C2
2 participants
@btriller @ankenyr
0