8000 Publication revoke by nbradac · Pull Request #1781 · aeron-io/aeron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Publication revoke #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
May 23, 2025
Merged

Publication revoke #1781

merged 41 commits into from
May 23, 2025

Conversation

nbradac
Copy link
Contributor
@nbradac nbradac commented Apr 17, 2025 •
edited
Loading

No description provided.

nbradac added 23 commits March 25, 2025 16:10
@nbradac
[Java] initial revoke POC
32aca52
@nbradac
[Java] network/ipc revoke basics are in
72de9ca
@nbradac
[Java] revoke works against spies
ce159eb
@nbradac
[Java] tighten up system tests, cleanup code a bit
0b29974
@nbradac
[Java] add agent logging for revoke events, add log buffer metadata i…
f6246f3 
…sPublicationRevoked flag
@nbradac
[Java] split out pub/sub side agent events, add system counters
e83d880
@nbradac
[Java] remove extra IpcPublication transitionToLinger
4ce7a41
@nbradac
Merge branch 'master' into pub-revoke
7f6b22f
@nbradac
[Java] refactor processPendingLoss()
69fc37f
@nbradac
[Java] fix IpcPublication, update system test to support C media driver
7a9b9bc
@nbradac
[C] initial C driver support for pub revoke
f7a021c
@nbradac
[Java] concurrent publications revoked by a separate publication are …
69b9e7f 
…not automatically closed
@nbradac
[C] add client APIs for revoke()
0ff558c
@nbradac
[Java] add revokeTestExclusive
1e301a6
@nbradac
[C,CppW] add revoke methods to C++ wrapper objects, add system tests …
ef1e8e1 
…for revoke
@nbradac
[Java] checkstyle
a116c7c
@nbradac
Merge branch 'master' into pub-revoke
0bae2d3
@nbradac
[C] remove case statement fallthrough
30c78c2
@nbradac
[C] add agent logging for revoke events
53f10c3
@nbradac
[C] add fall through comment
704937d
@nbradac
[C] cleanup a few TODOs
0a872dc
@nbradac
[Java] update onStatusMessage to mirror logic in the C driver
0907614
@nbradac
Merge branch 'master' into pub-revoke
fb58bb4
nbradac
nbradac commented Apr 30, 2025
View reviewed changes
nbradac
nbradac commented Apr 30, 2025
View reviewed changes
nbradac
nbradac commented Apr 30, 2025
View reviewed changes
@nbradac nbradac marked this pull request as ready for review April 30, 2025 15:54
@nbradac nbradac requested review from vyazelenko and mikeb01 April 30, 2025 15:54
nbradac
nbradac commented Apr 30, 2025
View reviewed changes
nbradac
nbradac commented May 16, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2025
View reviewed changes
mikeb01
mikeb01 reviewed May 20, 2025
View reviewed changes
mikeb01
mikeb01 reviewed May 20, 2025
View reviewed changes
mikeb01
mikeb01 reviewed May 21, 2025
View reviewed changes
mikeb01
mikeb01 reviewed May 21, 2025
View reviewed changes
mikeb01
mikeb01 reviewed May 21, 2025
View reviewed changes
mikeb01
mikeb01 reviewed May 21, 2025
View reviewed changes
@mikeb01
Copy link
Contributor
mikeb01 commented May 21, 2025

This is looking good. However, I would like to see some tests for multicast and MDC with multiple subscriptions to ensure that the events are propagated correctly out to all clients. It would be good to run these tests with multiple drivers for the subscription clients to poke that behaviour.

@vyazelenko vyazelenko merged commit c9477c4 into aeron-io:master May 23, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeb01 mikeb01 mikeb01 left review comments

@vyazelenko vyazelenko Awaiting requested review from vyazelenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbradac @mikeb01 @vyazelenko
0