10000 synchronize session ids across cluster nodes by ryanoftalltrees · Pull Request #1774 · aeron-io/aeron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

synchronize session ids across cluster nodes #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 15, 2025
Merged

synchronize session ids across cluster nodes #1774

merged 11 commits into from
Apr 15, 2025

Conversation

ryanoftalltrees
Copy link
Contributor

No description provided.

@ryanoftalltrees
Copy link
Contributor Author

I left the option to set the session id outside of the constructor, but if the approach of reusing rejected session ids works, then we may not need it. I also left the option to create a KeepAlive object that requires a client and one that doesn't.

@ryanoftalltrees ryanoftalltrees requested a review from mikeb01 April 2, 2025 17:55
vyazelenko
vyazelenko requested changes Apr 2, 2025
View reviewed changes
@vyazelenko
Copy link
Contributor

That new test is failing in CI.
https://github.com/aeron-io/aeron/actions/runs/14226204604

@ryanoftalltrees ryanoftalltrees marked this pull request as draft April 3, 2025 21:35
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 8, 2025
View reviewed changes
@ryanoftalltrees ryanoftalltrees marked this pull request as ready for review April 9, 2025 15:14
vyazelenko
vyazelenko requested changes Apr 9, 2025
View reviewed changes
vyazelenko
vyazelenko requested changes Apr 10, 2025
View reviewed changes
vyazelenko
vyazelenko requested changes Apr 10, 2025
View reviewed changes
vyazelenko
vyazelenko previously requested changes Apr 14, 2025
View reviewed changes
@vyazelenko vyazelenko merged commit 6bc6b7d into master Apr 15, 2025
44 checks passed
@vyazelenko vyazelenko mentioned this pull request Apr 15, 2025
Closed
vyazelenko added a commit that referenced this pull request Apr 15, 2025
@vyazelenko
[Java] Tidy up after #1774.
182a743
vyazelenko pushed a commit that referenced this pull request Apr 15, 2025
@ryanoftalltrees @vyazelenko
synchronize session ids across cluster nodes (#1774)
6bfb34b 
* synchronize session ids across cluster nodes

* Changed the approach to tracking session ids across nodes

* fix failing test

* Use committed session Id for snapshots

* Cleanup imports

* Style issues

* Increase test timeout

* changes from suggestions

* increment nextCommittedSessionId after session is open

* Prevent session id from going backwards

* consistency on session id integrity checks

(cherry picked from commit 6bc6b7d)
vyazelenko added a commit that referenced this pull request Apr 15, 2025
@vyazelenko
[Java] Tidy up after #1774.
440afea 
(cherry picked from commit 182a743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyazelenko vyazelenko vyazelenko left review comments

@mikeb01 mikeb01 Awaiting requested review from mikeb01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanoftalltrees @vyazelenko
0