[Java] Add support for changing term buffer length and MTU in the Cluster log. #1233
<
8000
div class="d-flex flex-order-2 flex-md-order-1 mx-2">
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th an empty recordings list.
…loading from the disc and appending new entries + use different sorting for snapshot entries and term entries with the same leadershipId.
…ged if recording log is truncated to the latest valid snapshot.
|
Using the term "truncate" on a recording log is confusing. It implies the log on the archive is truncated. We need to make it clear that this function creates a new recording log, old one is backed up, that allows the cluster to restart from the latest snapshot with a new cluster log. The old log remains untouched and can be archived or deleted as a separate operation. Something like "rebase log from snapshot. |
…` and backup existing file before creating a new recording log. Clarify that the old file is available under new name `recording.log.bak`.
|
@mjpt777 I pushed a change that renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature that allows a Cluster to be restarted with the term buffer length and/or MTU changed. This requires truncating an existing recording log to the latest valid snapshot, i.e. Cluster is starting from a snapshot only. The new API to do such truncation is provided via the
ClusterTool(i.e.io.aeron.cluster.ClusterTool#truncateRecordingLogandtruncate-recording-logcommand).Besides this feature this PR also contains a fix for keeping entries properly sorted in the
RecodingLog.