Response is not-nil if error is nil #376

alexandear · 2023-02-23T09:26:43Z

This PR removes if resp != nil check when creating a session in proxy.go.

The resp object cannot be nil in this code, as it is assigned the return value of httpClient.Do(req) method call, which returns a non-nil response object or an `error if the request could not be sent or the server returns an error response. From the documentation:

If the returned error is nil, the Response will contain a non-nil Body which the user is expected to close.
...
The request Body, if non-nil, will be closed by the underlying Transport, even on errors.

Actually, the code has leaked resources, but in proxy_test.go. Every call to http.Get must be accompanied by rsp.Body.Close() call. These places can be found by bodyclose linter.

vania-pooh · 2023-02-26T17:40:18Z

@alexandear correct, but let's just do defer resp.Body.Close() after err != nil check. Logging is not needed here.

alexandear · 2023-02-27T08:20:19Z

@vania-pooh done

vania-pooh · 2023-02-27T16:24:10Z

@alexandear thank you for contribution.

Response is not-nil if error is nil

0ba3658

vania-pooh merged commit 914ace9 into aerokube:master Feb 27, 2023

alexandear deleted the resp-is-not-nil branch February 27, 2023 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Response is not-nil if error is nil #376

Response is not-nil if error is nil #376

Response is not-nil if error is nil #376

Response is not-nil if error is nil #376

Conversation