Fix signature ping #302
Closed
Fix signature ping #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: prevent active_connections from blocking * feat: add SETNX, ECHO, TYPE, EXPIRETIME, PEXPIRETIME, HTTL, HPTTL, HEXPIRE, HPEXIRE, HEXPIREAT, HPEXPIREAT, HEXPIRETIME, HPEXPIRETIME, HPERSIST --------- Co-authored-by: AverageADF <youraverageantoinedupontfan@gmail.com> Co-authored-by: ArtemIsmagilov <artem.ismagilov.2000@mail.ru>
|
Thanks @ArtemIsmagilov, this was also cherry-picked into #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @aembke ! I would like to correct your signature on the PING command. This command should accept an optional argument message. I am glad that you support commands, for example incr and inctby. For some reason in redis-rs they have incrby implementation in one command incr.
This is exactly the problem I have just solved.
If something is missing or wrong, let me know.
After your cherry pick my commit sequence was broken, try to be more careful with this operation)
https://valkey.io/commands/ping/
https://redis.io/docs/latest/commands/ping/