8000 [ENH,BUG] added weighted elastic barycenter and fix cache issue in subgradient method by maxwell1503 · Pull Request #1563 · aeon-toolkit/aeon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH,BUG] added weighted elastic barycenter and fix cache issue in subgradient method #1563

Merged
merged 7 commits into from
May 25, 2024
Merged

[ENH,BUG] added weighted elastic barycenter and fix cache issue in subgradient method #1563

merged 7 commits into from
May 25, 2024

Conversation

maxwell1503
Copy link
Contributor
@maxwell1503 maxwell1503 commented May 24, 2024 •
edited by hadifawaz1999
Loading

Reference Issues/PRs

Solve #1251

What does this implement/fix? Explain your changes.

  • Added weighted version of elastic barycenter by adding an optional parameter (weights, by default equals to ones)
  • Fixed the cache issue in sub gradient method by making a copy of barycenter

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement labels May 24, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$, $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

chrisholder
chrisholder requested changes May 25, 2024
View reviewed changes
Copy link
Contributor
@chrisholder chrisholder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition thanks so much!

@hadifawaz1999 hadifawaz1999 merged commit 5146279 into aeon-toolkit:main May 25, 2024
14 checks passed
@TonyBagnall
Copy link
Contributor

great, thanks

@chrisholder chrisholder mentioned this pull request May 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisholder chrisholder chrisholder approved these changes

@TonyBagnall TonyBagnall Awaiting requested review from TonyBagnall TonyBagnall is a code owner

Assignees
No one assigned
Labels
bug Something isn't working clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxwell1503 @TonyBagnall @chrisholder @hadifawaz1999
0