Rename "armcrypto" implementations to "neon_aes" #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Arm 64-bit architecture contains a number of architecture extensions relevant to the AEGIS family of algorithms, however currently libaegis only checks and exposes FEAT_AES. In particular: * FEAT_SHA3 contains the Neon EOR3 and BCAX instructions which can be useful for e.g. combining pairs of exclusive-or instructions. * FEAT_SVE_AES provides SVE versions of the existing AESE and AESMC instructions. These can be beneficial on micro-architectures with longer vectors. * FEAT_SVE2 provides SVE2 versions of the EOR3 and BCAX instructions, mirroring the Neon versions but for SVE vectors. As a first step towards supporting these new extensions, rename the existing code to disambiguate away from "armcrypto" and instead refer to the exact "neon_aes" extension that the code depends on.
|
Thank you! SVE implementations would indeed be really good to have in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Arm 64-bit architecture contains a number of architecture extensions relevant to the AEGIS family of algorithms, however currently libaegis only checks and exposes
FEAT_AES. In particular:FEAT_SHA3contains the NeonEOR3andBCAXinstructions which can be useful for e.g. combining pairs of exclusive-or instructions.FEAT_SVE_AESprovides SVE versions of the existingAESEandAESMCinstructions. These can be beneficial on micro-architectures with longer vectors.FEAT_SVE2provides SVE2 versions of theEOR3andBCAXinstructions, mirroring the Neon versions but for SVE vectors.As a first step towards supporting these new extensions, rename the existing code to disambiguate away from "armcrypto" and instead refer to the exact "neon_aes" extension that the code depends on.