8000 Add typehints; Move to modern pyproject.toml; add ruff,isort,black,mypy; Overhauled library by jonded94 · Pull Request #2 · ae-foster/rdbgenerate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add typehints; Move to modern pyproject.toml; add ruff,isort,black,mypy; Overhauled library #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add typehints; Move to modern pyproject.toml; add ruff,isort,black,mypy; Overhauled library #2

wants to merge 17 commits into from

Conversation

jonded94
Copy link
@jonded94 jonded94 commented Mar 8, 2024
  • Added typehints across the entire library
  • Removed deprecated setup.py mechanism, use modern pyproject.toml
  • Made library test pos 8000 itive under modern linters such as ruff, isort, black, mypy
  • Overhauled library by adding a contextmanager based RDBWriter class that can dynamically add new items
  • Overhauled CRC mechanism; instead of one bulk computation, CRC is now computed on every new byte; this in turn allows gradual streaming of items

@jonded94
Copy link
Author
jonded94 commented Apr 3, 2024

@ae-foster hey, any updates on this? :) I know that this is quite the 8000 involved PR, practically rebuilding large parts of the repository.

Are you against merging this? Otherwise, a potential fork could be also possible, although I'm personally against it since there is no inherent need for multiple Python packages for generating .rdb files.

@ae-foster
Copy link
Owner

Wow thank you @jonded94 . My apologies, this is rather an old project so I have not been checking for updates regularly. Let me try and review these changes and get back to you ASAP

@jonded94
Copy link
Author
jonded94 commented Aug 6, 2024

Bi-monthly ping again.. :) 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonded94 @ae-foster
0