-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Signature Support #355
Conversation
Hi @moorereason! Is there anything else we can do to the proposal to move this ahead? |
Two things:
Once those are done, I'm in favor of merging. |
- added support for sha512 - added notes to docs
I've updated to latest, added support for |
This looks great. And you added a generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current implementation of the
payload-hash-sha256
andpayload-hash-sha1
match types only considers secrets provided one per header. To support secret rolling (as used by Stripe), I propose supporting the following scheme:Initially, we have the following:
But when we're rolling secrets, we send requests with a signature from the old secret, and the new secret for a time frame allowing administrators to update code or environment variables to the new secret. This gives us a header that looks like this instead:
Which is essentially:
This is the same process for the
sha1
type.