8000 [pull] master from digitalmethodsinitiative:master by pull[bot] · Pull Request #211 · admariner/4cat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[pull] master from digitalmethodsinitiative:master #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy 8000 statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2025
Merged

[pull] master from digitalmethodsinitiative:master #211

merged 5 commits into from
May 6, 2025

Conversation

pull[bot]
Copy link
@pull pull bot commented May 6, 2025 •
edited by sourcery-ai bot
Loading

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update Docker Compose configuration, Bluesky and Douyin datasource handling, and dependency management

Bug Fixes:

  • Handle potential undefined keys in Douyin datasource parsing
  • Add token expiration handling in Bluesky authentication

Enhancements:

  • Improve error handling for Bluesky session authentication
  • Refactor Douyin datasource item mapping to be more robust

Deployment:

  • Modify Docker Compose to support custom server bind address
  • Update volume mounting configurations

Chores:

  • Update atproto dependency to a more recent version

@pull pull bot added the ⤵️ pull label May 6, 2025
@pull pull bot merged commit ecb2147 into admariner:master May 6, 2025
@sourcery-ai Sourcery AI
Copy link
sourcery-ai bot commented May 6, 2025 •
edited
Loading

Reviewer's Guide

This pull request updates Docker port configurations for the frontend service by incorporating SERVER_BIND_ADDRESS, enhances data parsing resilience within the Douyin datasource through safer dictionary access, implements session token refresh logic for the Bsky datasource to handle expirations, and upgrades the atproto dependency to a newer version.

File-Level Changes

Change Details Files
Updated frontend service port mapping to use SERVER_BIND_ADDRESS.
  • Modified the frontend service's port definition from ${PUBLIC_PORT}:5000 to ${SERVER_BIND_ADDRESS}:${PUBLIC_PORT}:5000 in both compose files, allowing binding to a specific network interface.
  • Commented out a named volume line for PostgreSQL in docker-compose_build.yml (effects of this change should be verified).
 docker-compose_build.yml
docker-compose.yml
Enhanced robustness of data parsing in the Douyin datasource.
  • Refactored dictionary access for fields like mix_info_key, hashtag_key, and mention_key using .get() and conditional existence checks to prevent KeyError exceptions when parsing API responses.
  • Ensured default values or 'N/A' are used if expected data fields are absent or undefined in the item structure (e.g., for mix_current_episode, collection_id, collection_name).
 datasources/douyin/search_douyin.py
Implemented token refresh logic in Bsky datasource.
  • Added a try-except block around client.login(session_string=...) to catch BadRequestError.
  • Specifically checks if the error indicates an expired token and, if so, attempts to re-login using stored username and password credentials.
  • Raises a ValueError if re-login is needed but credentials are not available, prompting for a manual re-login action from the user if needed
 datasources/bsky/search_bsky.py
Upgraded atproto dependency.
  • Changed the version requirement for the atproto package from ==0.0.57 to >=0.0.58.
 setup.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⤵️ pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dale-wahl
0