8000 feat: allow specifying sender address in email provider settings by astappiev · Pull Request #315 · adityachandelgit/BookLore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: allow specifying sender address in email provider settings #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

feat: allow specifying sender address in email provider settings #315

merged 2 commits into from
May 19, 2025
+30 −9

Conversation

astappiev
Copy link
Contributor

Solves #286, #300

@adityachandelgit
Copy link
Owner 

<ng-template pTemplate="header">
    <tr>
      <th style="width: 6%;">Default</th>
      <th style="width: 10%;">Name</th>
      <th style="width: 15%;">Host</th>
      <th style="width: 6%;">Port</th>
      <th style="width: 14%;">Username</th>
      <th style="width: 12%;">Password</th>
      <th style="width: 12%;">From Address</th>
      <th style="width: 5%;">Auth</th>
      <th style="width: 5%;">StartTLS</th>
      <th style="width: 7%;">Edit</th>
      <th style="width: 8%;">Delete</th>
    </tr>
  </ng-template>

<td>
  <input *ngIf="provider.isEditing" type="text" [(ngModel)]="provider.fromAddress" class="p-inputtext w-full"/>
  <span *ngIf="!provider.isEditing">{{ provider.fromAddress }}</span>
</td>

<td class="text-center">
  <p-checkbox
    [(ngModel)]="provider.auth"
    [binary]="true"
    [disabled]="!provider.isEditing">
  </p-checkbox>
</td>

I’d prefer to place “From Address” before the Auth and StartTLS checkboxes in the table for better visual alignment.

@p2bauer
Copy link
p2bauer commented May 18, 2025

Just a suggestion - might be advantageous to bind the from to the destination email to work better with multi-user support? (ie. send-to-kindle for different accounts expect different senders?)

But this is great already, thank you!

@astappiev
Copy link
Contributor Author

@adityachandelgit I changed the order of fields in a form.
@p2bauer I'm not sure if this makes sense. In the current way email providers are implemented, you can add multiple providers with the same credentials, but with different from addresses.

I think the providers/recipients part should be re-evaluated, by first, defining requirements and considering multi-user scenarios in self-hosted app.

@adityachandelgit adityachandelgit added enhancement Improvement to an existing feature patch Backward-compatible bug fixes or tweaks labels May 19, 2025
@adityachandelgit adityachandelgit merged commit 2cf1042 into adityachandelgit:develop May 19, 2025
@github-project-automation github-project-automation bot moved this to Done in BookLore May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature patch Backward-compatible bug fixes or tweaks
Projects
BookLore
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astappiev @adityachandelgit @p2bauer
0